Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup build and fuzz-test GH workflows #1410

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Cleanup build and fuzz-test GH workflows #1410

merged 3 commits into from
Apr 25, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR cleans up GH workflows in a way that it doesn't checkout git submodules anymore for the workflows which don't need it. It also adds names to some steps which were missing it.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 21, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 21, 2023 13:44
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 21, 2023 13:44
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-609-remove-redundant-steps-in-gh-workflows branch 2 times, most recently from 9fc6d79 to b946749 Compare April 24, 2023 11:48
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-609-remove-redundant-steps-in-gh-workflows branch from b946749 to 883aa18 Compare April 25, 2023 08:44
@Stefan-Ethernal Stefan-Ethernal merged commit 7ca7f43 into develop Apr 25, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-609-remove-redundant-steps-in-gh-workflows branch April 25, 2023 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
vcastellm
vcastellm reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm left review comments

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Stefan-Ethernal @vcastellm @Nemanja0x @stana-miric