Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken unit test due to changed loadtest inputs #1432

Merged
merged 7 commits into from
Apr 27, 2023
Merged

fix broken unit test due to changed loadtest inputs #1432

merged 7 commits into from
Apr 27, 2023

Conversation

gatsbyz
Copy link
Contributor

@gatsbyz gatsbyz commented Apr 25, 2023

No description provided.

@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 13:58 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 14:25 — with GitHub Actions Inactive
@gatsbyz gatsbyz force-pushed the jesse/fix-unit-test branch 4 times, most recently from 2864e78 to 4c50a64 Compare April 25, 2023 17:22
@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 17:22 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 17:47 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 21:49 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 22:20 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 25, 2023 22:46 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 03:04 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 03:30 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 04:26 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 04:41 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 05:05 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 05:37 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 05:43 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 06:04 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 06:09 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet April 26, 2023 06:14 — with GitHub Actions Inactive
@Stefan-Ethernal
Copy link
Collaborator

@gatsbyz consider returning back Slack notifications for Nightly builds through this PR, because those were deleted accidentally I suppose through #1430 (024d011#diff-0d5658b415099a82c11c03a06ca4ec765b4003a1f4b2f3f1943980a882cf8aa6L46-L49).

@gatsbyz
Copy link
Contributor Author

gatsbyz commented Apr 26, 2023 •
edited

@Stefan-Ethernal that was a duplicated part of the code. i think it was a rebase error on my part. so the notification block actually starts 024d011#diff-0d5658b415099a82c11c03a06ca4ec765b4003a1f4b2f3f1943980a882cf8aa6L67-L71 here

@gatsbyz gatsbyz changed the title Jesse/fix unit test fix broken unit test due to changed loadtest inputs Apr 26, 2023
vcastellm
vcastellm approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatsbyz @vcastellm
Update .github/workflows/manual.deploy.nightly.devnet.yml
f1b33a3 
Co-authored-by: Victor Castell <victor@polygon.technology>
@Stefan-Ethernal
Copy link
Collaborator

Stefan-Ethernal commented Apr 26, 2023 •
edited

@Stefan-Ethernal that was a duplicated part of the code. i think it was a rebase error on my part. so the notification block actually starts 024d011#diff-0d5658b415099a82c11c03a06ca4ec765b4003a1f4b2f3f1943980a882cf8aa6L67-L71 here

Ok, but strange there weren't Slack notifications for yesterday's NB. 🤔 There is an error in nightly workflow (https://github.com/0xPolygon/polygon-edge/actions/runs/4803384951), so it is fails when triggered:

Invalid workflow file: .github/workflows/nightly.yml#L52
The workflow is not valid. .github/workflows/nightly.yml (Line: 52, Col: 28): Invalid secret, TF_VAR_COMPANY_NAME is not defined in the referenced workflow.

@gatsbyz gatsbyz merged commit c6c8973 into develop Apr 27, 2023
@gatsbyz gatsbyz deleted the jesse/fix-unit-test branch April 27, 2023 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

@zuiris zuiris Awaiting requested review from zuiris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gatsbyz @Stefan-Ethernal @vcastellm @Nemanja0x