Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Txn.AddLog function and add comments #1465

Merged
merged 1 commit into from
May 4, 2023
Merged

Remove Txn.AddLog function and add comments #1465

merged 1 commit into from
May 4, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

It is noticed that AddLog function is unused and is removed. Also some function comments are added.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal changed the title Remove AddLog function and add comments Remove Txn.AddLog function and add comments May 2, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this May 2, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label May 2, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 2, 2023 12:30
@Stefan-Ethernal Stefan-Ethernal requested review from Nemanja0x, vcastellm and a team May 3, 2023 13:34
@Nemanja0x
Copy link
Contributor

I would rather not to remove AddLog, because we do not know when we might need it, but ok.

@Stefan-Ethernal Stefan-Ethernal merged commit 434e8bf into develop May 4, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-625-remove-txn-add-log-function branch May 4, 2023 07:24
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
vcastellm
vcastellm reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm left review comments

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Stefan-Ethernal @Nemanja0x @vcastellm @goran-ethernal