-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ethereum tests spec to v10.4 #1466
Merged
begmaroman
merged 14 commits into
develop
from
EVM-56-updating-to-the-latest-version-of-ethereum-tests
May 22, 2023
Merged
Update Ethereum tests spec to v10.4 #1466
begmaroman
merged 14 commits into
develop
from
EVM-56-updating-to-the-latest-version-of-ethereum-tests
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-the-latest-version-of-ethereum-tests
…-the-latest-version-of-ethereum-tests
…-the-latest-version-of-ethereum-tests
begmaroman
changed the title
Update Ethereum tests spec to the latest one
Update Ethereum tests spec to v10.4
May 19, 2023
vcastellm
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
igorcrevar
reviewed
May 22, 2023
igorcrevar
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just a small neat-pick
begmaroman
deleted the
EVM-56-updating-to-the-latest-version-of-ethereum-tests
branch
May 22, 2023 15:12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated test cases suite to v10.4. This version includes london hardfork test cases and does not inlude the merge one and all further updates. Currently, london hardfork test cases are ignored since there are some differences in gas consumption.
Also, TestEVM is not needed anymore since those test cases were moved to the regular state tests. Eventually, if there is any difference in the tx execution, the block hash is going to be different and a test will fail.
Changes include
Checklist
Testing