Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ethereum tests spec to v10.4 #1466

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented May 2, 2023

Description

Updated test cases suite to v10.4. This version includes london hardfork test cases and does not inlude the merge one and all further updates. Currently, london hardfork test cases are ignored since there are some differences in gas consumption.

Also, TestEVM is not needed anymore since those test cases were moved to the regular state tests. Eventually, if there is any difference in the tx execution, the block hash is going to be different and a test will fail.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this May 19, 2023
@begmaroman begmaroman requested a review from vcastellm May 19, 2023 11:50
@begmaroman begmaroman changed the title Update Ethereum tests spec to the latest one Update Ethereum tests spec to v10.4 May 19, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begmaroman begmaroman marked this pull request as ready for review May 22, 2023 12:21
tests/state_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@igorcrevar igorcrevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just a small neat-pick

@begmaroman begmaroman merged commit 97e07b2 into develop May 22, 2023
@begmaroman begmaroman deleted the EVM-56-updating-to-the-latest-version-of-ethereum-tests branch May 22, 2023 15:12
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants