Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lint GH workflow #1512

Merged
merged 3 commits into from
May 16, 2023
Merged

Fix Lint GH workflow #1512

merged 3 commits into from
May 16, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented May 16, 2023

Description

Linting GH workflow does not get triggered on some occasions (most notable is external collaborators' pull requests. E.g.: #1503). This PR tries to fix that, by removing ignored branches.

Also, it is noticed that linting can fail due to timeout elapses, which is mitigated by increasing the timeout.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label May 16, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this May 16, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 16, 2023 08:36
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review May 16, 2023 08:36
@Stefan-Ethernal Stefan-Ethernal changed the title Remove ignored branches and increase timeout Fix Lint GH workflow May 16, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 16, 2023 14:25
@Stefan-Ethernal Stefan-Ethernal merged commit c349064 into develop May 16, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-650-fix-lint-gh-workflow branch May 16, 2023 18:43
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants