Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-666: Fix eth_getLogs index issue #1533

Merged
merged 3 commits into from
May 23, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented May 22, 2023

Description

This PR fixes issue where eth_getLog rpc call did not return correct values for LogIndex for block logs.

Before, the LogIndex field was set by transaction instead of block. For example, if block had two transactions with two logs each, the call would return log indexes: 0, 1, 0, 1, instead of: 0, 1, 2, 3.

This PR added a UT for this.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal requested a review from a team May 22, 2023 20:10
@goran-ethernal goran-ethernal self-assigned this May 22, 2023
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label May 22, 2023
@goran-ethernal goran-ethernal force-pushed the EVM-666-fix-eth_logs-log-index-issue branch from f620b3c to ad920a2 Compare May 22, 2023 20:12
@goran-ethernal goran-ethernal marked this pull request as ready for review May 22, 2023 20:12
@goran-ethernal goran-ethernal force-pushed the EVM-666-fix-eth_logs-log-index-issue branch from ad920a2 to e2669bf Compare May 22, 2023 20:16
@rzmahmood
Copy link
Contributor

Just confirming, this will fix for logs returned by both eth_getLogs and eth_getBlockByNumber?

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsonrpc/filter_manager.go Outdated Show resolved Hide resolved
@Stefan-Ethernal
Copy link
Collaborator

Just confirming, this will fix for logs returned by both eth_getLogs and eth_getBlockByNumber?

AFAIK, the eth_getBlockByNumber endpoint does not return logs. So this PR affects the eth_getLogs and eth_getFilterLogs endpoints.

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goran-ethernal goran-ethernal merged commit 3f3e071 into develop May 23, 2023
@goran-ethernal goran-ethernal deleted the EVM-666-fix-eth_logs-log-index-issue branch May 23, 2023 09:38
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants