EVM-525 Write load test for adding peers #1537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend
TestPeerAdditionDeletion
with testingAddPeers
when the peer number is significantly big. This test should address TODO comment in the test.There was a deadlock because discovery was subscribed to network server events using
s.SubscribeFn(context.Background(), discoveryService.HandleNetworkEvent)
.In
server_discovery.go
, there was a definition of a custom callback function:and that callback function was called by the routing table library on the line
_, err := d.routingTable.TryAddPeer(peerID, false, false)
insideHandleNetworkEvent
handler.The method addToDialQueue is defined as:
Emitting an event is a blocking function, new event is being emitted from the routine which handles event and each subscription channel used in the network server is not buffered. All these factors can lead to a deadlock.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing