-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Subnet Genesis Finalize #1545
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just curious, do you remember what was the error message they were getting when running supernet command after it was initialized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you rebase @paulgoleary ? |
… gensis idempotent so it can be re-run.
3e68e0c
to
86ff411
Compare
@vcastellm @paulgoleary FYI, I've rebased. If CI is 🟢, we can merge it. |
Description
ethgo
: umbracle/ethgo@7700caeBug in
ethgo
causes problems with finalize and also elsewhere - the bridge I believe.Please provide a detailed description of what was done in this PR
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it