Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return hex encoded number in eth_getBlockTransactionCountByNumber endpoint #1559

Merged
merged 3 commits into from
May 26, 2023
Merged

Return hex encoded number in eth_getBlockTransactionCountByNumber endpoint #1559

merged 3 commits into from
May 26, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented May 26, 2023 •
edited

Description

Return the hex-encoded number instead of the actual number in eth_getBlockTransactionCountByNumber endpoint

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this May 26, 2023
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label May 26, 2023
@begmaroman begmaroman merged commit 709a1d2 into develop May 26, 2023
@begmaroman begmaroman deleted the feature/EVM-655 branch May 26, 2023 15:54
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@begmaroman @vcastellm @igorcrevar @goran-ethernal