-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent ACL admins to remove themselves #1578
Conversation
The admin should not be able to remove themselves when there's only one admin, otherwise I think they should be able to remove themselves, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, @QEDK's comment makes sense as well.
We can not count how many admins there are in the lists due to limitation of the state. This was the first idea but we needed to adapt it to this. |
Description
This PR implements a protection to ACLs so going forward an admin can not remove himself from the admins list, it should be removed by another admin.
Changes include
Checklist
Testing