Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Prometheus metrics expiration time #1592

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Remove Prometheus metrics expiration time #1592

merged 2 commits into from
Jun 8, 2023

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Jun 7, 2023 •
edited by 0xCVH

Description

Please provide a detailed description of what was done in this PR

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@vcastellm vcastellm marked this pull request as ready for review June 7, 2023 10:40
@vcastellm vcastellm self-assigned this Jun 7, 2023
@vcastellm vcastellm added the bug fix Functionality that fixes a bug label Jun 7, 2023
@vcastellm vcastellm requested a review from a team June 7, 2023 10:41
@vcastellm vcastellm merged commit 67d4970 into develop Jun 8, 2023
7 checks passed
@vcastellm vcastellm deleted the EVM-681-remove-prometheus-metrics-expiration-time branch June 8, 2023 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcastellm @igorcrevar @Stefan-Ethernal @goran-ethernal