Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-680 Dial queue issues fixes #1593

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Jun 7, 2023

Description

There are multiple small bugs inside dial queue that need to be addressed
For example:

  • after deleting task from the queue, corresponding map is not updated, only binary heap is
  • if task is added to queue, there is no check that same task is already on the queue
  • some other small issues
  • remove unnecessary network server subscriptions, simplify code

Slots will be added through separated pr

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jun 7, 2023
@igorcrevar igorcrevar self-assigned this Jun 7, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch 16 times, most recently from 08842ae to d9df74d Compare June 9, 2023 08:52
@igorcrevar igorcrevar changed the title EVM-680 Dial queue issues fixes EVM-680 Slots & Dial queue issues fixes Jun 9, 2023
@igorcrevar igorcrevar marked this pull request as ready for review June 9, 2023 10:03
@igorcrevar igorcrevar changed the title EVM-680 Slots & Dial queue issues fixes EVM-680 Dial queue issues fixes Jun 9, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch from d9df74d to 606cf42 Compare June 9, 2023 12:41
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch from 74a40ad to cc1331e Compare June 13, 2023 14:46
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch from cc1331e to 9062325 Compare June 19, 2023 09:26
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch from 9062325 to 805a47c Compare June 28, 2023 16:40
@igorcrevar igorcrevar merged commit 4a083ca into develop Jul 7, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-680-dial_queue_fixes branch July 7, 2023 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants