Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-528]: Resolve TODOs in state code #1597

Merged
merged 4 commits into from
Jun 12, 2023
Merged

[EVM-528]: Resolve TODOs in state code #1597

merged 4 commits into from
Jun 12, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jun 8, 2023 •
edited

Description

Resolved TODOs in state package. Some TODOs are obsolete and removed.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal requested a review from a team June 8, 2023 08:02
@goran-ethernal goran-ethernal self-assigned this Jun 8, 2023
@goran-ethernal goran-ethernal marked this pull request as ready for review June 8, 2023 08:03
Stefan-Ethernal
Stefan-Ethernal reviewed Jun 9, 2023
View reviewed changes
state/immutable-trie/trie.go Outdated Show resolved Hide resolved
state/txn.go Show resolved Hide resolved
@Stefan-Ethernal
Copy link
Collaborator

Stefan-Ethernal commented Jun 10, 2023 •
edited

IBFT E2E tests triggered manually:

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-528-Resolve-TODOs-in-state-code branch from 81f4b5d to 0fa21d9 Compare June 10, 2023 14:36
Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goran-ethernal goran-ethernal merged commit ed64216 into develop Jun 12, 2023
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
@goran-ethernal goran-ethernal deleted the EVM-528-Resolve-TODOs-in-state-code branch June 12, 2023 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goran-ethernal @Stefan-Ethernal @vcastellm @igorcrevar