Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-687 Dial queue slots #1601

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Jun 9, 2023

Description

slots concept in order to limit maximal outbound connections:

  • func (s *Server) runDial() waits for something to be inserted into the queue
  • after task has been poped from the queue, it tries to take one slot for new outbound connection. If there are no available slots the routine is blocked
  • whenever disconnect/failed to connect events occurs, one slot is released and becomes available

This task is necessary in order to finish EVM-543

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar added the feature New update to Polygon Edge label Jun 9, 2023
@igorcrevar igorcrevar self-assigned this Jun 9, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-687-Dial_queue_slots branch 8 times, most recently from d55aa0a to 586ad7a Compare June 12, 2023 13:19
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch from cc1331e to 9062325 Compare June 19, 2023 09:26
@igorcrevar igorcrevar force-pushed the feature/EVM-687-Dial_queue_slots branch from 586ad7a to d0bf461 Compare June 19, 2023 09:27
@igorcrevar igorcrevar force-pushed the feature/EVM-680-dial_queue_fixes branch from 9062325 to 805a47c Compare June 28, 2023 16:40
@igorcrevar igorcrevar force-pushed the feature/EVM-687-Dial_queue_slots branch from d0bf461 to 5d96772 Compare June 28, 2023 16:41
Base automatically changed from feature/EVM-680-dial_queue_fixes to develop July 7, 2023 12:00
@igorcrevar igorcrevar force-pushed the feature/EVM-687-Dial_queue_slots branch 3 times, most recently from 2774c21 to c31c119 Compare July 7, 2023 12:11
@igorcrevar igorcrevar force-pushed the feature/EVM-687-Dial_queue_slots branch from c31c119 to a03e1ea Compare July 7, 2023 12:12
@igorcrevar igorcrevar merged commit 6e5cd75 into develop Jul 7, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-687-Dial_queue_slots branch July 7, 2023 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants