Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-689 The impact of database saving failures on Stake Manager func #1607

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

There is a possibility that if saving to the database fails, the stake manager may not function correctly, as it will permanently omit the events from the block on which the database saving failed.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jun 12, 2023
@igorcrevar igorcrevar self-assigned this Jun 12, 2023
@igorcrevar igorcrevar force-pushed the feature/stake_manager_missing_blocks branch from c9e097e to 6d15c5c Compare June 12, 2023 08:14
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorcrevar igorcrevar force-pushed the feature/stake_manager_missing_blocks branch from 6d15c5c to 5ecbd4b Compare June 12, 2023 08:19
@igorcrevar igorcrevar force-pushed the feature/stake_manager_missing_blocks branch from 5ecbd4b to 44c7f37 Compare June 12, 2023 08:21
@igorcrevar igorcrevar merged commit a0e359a into develop Jun 14, 2023
@igorcrevar igorcrevar deleted the feature/stake_manager_missing_blocks branch June 14, 2023 09:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants