Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TestStateSyncerManager_EventTracker_Sync #1608

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Jun 12, 2023

Description

Improve TestStateSyncerManager_EventTracker_Sync by deploying currently hardcoded contract as an artifact instead. Delete related TODO from the code.
File: consensus/polybft/state_sync_manager_test.go

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman merged commit 0db8cbb into develop Jun 12, 2023
6 checks passed
@begmaroman begmaroman deleted the feature/EVM-542 branch June 12, 2023 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants