Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix predeploy command to deploy contracts without a constructor #1612

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix predeploy command to deploy contracts without a constructor #1612

merged 1 commit into from
Jun 13, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR fixes genesis predeploy command, by allowing deployment of contracts that do not define constructor.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug Something isn't working label Jun 12, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 12, 2023 20:41
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jun 12, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-691-fix-predeploy-custom-contracts-without-a-constructor branch from 5395fea to 97531de Compare June 12, 2023 20:42
@Stefan-Ethernal Stefan-Ethernal merged commit d9b8aae into develop Jun 13, 2023
7 of 8 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-691-fix-predeploy-custom-contracts-without-a-constructor branch June 13, 2023 11:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Stefan-Ethernal @Nemanja0x @dusan-maksimovic @stana-miric @goran-ethernal