Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: match runtime errors with geth #1619

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

lolchocotaco
Copy link
Contributor

Description

Edge errors match verbatim with geth. It makes scanning for exact errors difficult. Made the following modifications to match this: https://github.com/ethereum/go-ethereum/blob/master/core/vm/errors.go#L25-L39

  • Updated ErrMaxCodeSizeExceeded string
  • Updated ErrExecutionReverted string
  • Added custom ErrStackUnderflow and ErrStackOverflow errors to match geth

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Additional comments

Some tooling relies on reading exact error runtime messages. Inconsistencies require custom tooling between geth / polygon-edge.

@github-actions
Copy link

github-actions bot commented Jun 13, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lolchocotaco
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@goran-ethernal
Copy link
Collaborator

Looks good, just note that there are some Lint errors that need to be fixed.

@Stefan-Ethernal Stefan-Ethernal merged commit f921f30 into 0xPolygon:develop Jun 19, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
@lolchocotaco lolchocotaco deleted the geth-errors branch June 20, 2023 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants