Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM-706]: Provide native token initial total supply #1623

Merged

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jun 15, 2023

Description

In 0xPolygon/edge-contracts@befb417, we added initial total supply when initializing native ERC20 tokens.

This PR adds that initial total supply parameter when initializing those tokens on start of child chain. Basically we run through the Alloc map in genesis, sum up all balances from all addresses (that are premined, except for the zero address since its a special case address), and initialize tokens with it.

This PR also added appropriate checks for this in the e2e tests.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal requested a review from a team June 15, 2023 09:34
@goran-ethernal goran-ethernal self-assigned this Jun 15, 2023
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Jun 15, 2023
@goran-ethernal goran-ethernal force-pushed the EVM-706-Provide-native-token-initial-total-supply branch from 32bae84 to ec12e67 Compare June 15, 2023 09:36
@goran-ethernal goran-ethernal force-pushed the EVM-706-Provide-native-token-initial-total-supply branch from ec12e67 to ad94cf4 Compare June 15, 2023 09:37
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from minor nitpicks.

e2e-polybft/e2e/consensus_test.go Outdated Show resolved Hide resolved
consensus/polybft/polybft.go Show resolved Hide resolved
@goran-ethernal goran-ethernal marked this pull request as ready for review June 15, 2023 09:47
@goran-ethernal goran-ethernal merged commit df3e91b into develop Jun 15, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-706-Provide-native-token-initial-total-supply branch June 15, 2023 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants