Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log contract deployment transaction details #1627

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

jelacamarko
Copy link
Contributor

@jelacamarko jelacamarko commented Jun 16, 2023

Description

Added Output Formatter to TxRelayer as TxRelayerOption.
Log deployment contract transaction details: from, gas, and gas price.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

txrelayer/txrelayer.go Outdated Show resolved Hide resolved
txrelayer/txrelayer.go Outdated Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal self-requested a review June 16, 2023 13:12
@jelacamarko jelacamarko force-pushed the EVM-709-log-deployment-contract-txn branch from 689695b to c3aad08 Compare June 20, 2023 10:02
@Stefan-Ethernal Stefan-Ethernal dismissed their stale review June 20, 2023 12:11

Dismissing it because I don't want to block merging of the PR, although I'm not entirely convinced that we need it.

@jelacamarko jelacamarko force-pushed the EVM-709-log-deployment-contract-txn branch from c3aad08 to 58a2813 Compare June 20, 2023 12:13
@jelacamarko jelacamarko merged commit 573dcb7 into develop Jun 20, 2023
7 checks passed
@jelacamarko jelacamarko deleted the EVM-709-log-deployment-contract-txn branch June 20, 2023 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants