Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go version to 1.20 #1636

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Bump Go version to 1.20 #1636

merged 4 commits into from
Jun 20, 2023

Conversation

vcastellm
Copy link
Contributor

Description

Change the necessary files for the upgrade.

@vcastellm vcastellm self-assigned this Jun 19, 2023
@vcastellm vcastellm marked this pull request as ready for review June 19, 2023 16:27
@vcastellm vcastellm requested a review from a team June 19, 2023 16:27
@Stefan-Ethernal
Copy link
Collaborator

I think there are two more places where we should bump version info to 1.20:

  1. go.mod file (and run go mod tidy afterward to update dependencies accordingly)
  2. scripts/README.md states 1.19 go version

Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vcastellm vcastellm merged commit 5dc3dc8 into develop Jun 20, 2023
6 checks passed
@vcastellm vcastellm deleted the EVM-711-upgrade-to-go-1-20 branch June 20, 2023 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcastellm @Stefan-Ethernal @igorcrevar @Nemanja0x