Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-701]: Validate ExitRootHash in CheckpointData #1638

Merged
merged 2 commits into from
Jun 20, 2023
Merged

[EVM-701]: Validate ExitRootHash in CheckpointData #1638

merged 2 commits into from
Jun 20, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jun 19, 2023 •
edited

Description

This PR introduces validation of provided ExitRootHash in CheckpointData in the proposal header ExtraData.

Since all validators collect exit events (needed to do L2-L1 transfers), they can validate the exit root hash provided by the block proposer in consensus, as an additional part of security.

This PR also added appropriate UTs.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal force-pushed the EVM-701-Validate-ExitRootHash-in-CheckpointData branch from ffb0a09 to 8ce9772 Compare June 19, 2023 13:18
@goran-ethernal goran-ethernal self-assigned this Jun 19, 2023
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Jun 19, 2023
@goran-ethernal goran-ethernal requested a review from a team June 19, 2023 13:18
@goran-ethernal goran-ethernal marked this pull request as ready for review June 19, 2023 13:21
@goran-ethernal goran-ethernal force-pushed the EVM-701-Validate-ExitRootHash-in-CheckpointData branch from 8ce9772 to e47f8ca Compare June 19, 2023 13:32
Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 19, 2023
View reviewed changes
consensus/polybft/fsm_test.go Show resolved Hide resolved
consensus/polybft/blockchain_wrapper.go Show resolved Hide resolved
consensus/polybft/extra.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal merged commit de084a9 into develop Jun 20, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-701-Validate-ExitRootHash-in-CheckpointData branch June 20, 2023 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goran-ethernal @igorcrevar @Stefan-Ethernal @stana-miric