Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPoAPoSSwitch fixed #1639

Merged
merged 1 commit into from
Jun 22, 2023
Merged

TestPoAPoSSwitch fixed #1639

merged 1 commit into from
Jun 22, 2023

Conversation

Nemanja0x
Copy link
Contributor

@Nemanja0x Nemanja0x commented Jun 20, 2023 •
edited

Description

go-ibft supports 4 and more nodes. For those purposes the TestPoAPoSSwitch test was modified to run with 4 validators.

https://arxiv.org/pdf/1909.10194.pdf (page 16, definition 7)
https://groups.csail.mit.edu/tds/papers/Lynch/jacm88.pdf

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Nemanja0x Nemanja0x marked this pull request as ready for review June 20, 2023 06:44
@Stefan-Ethernal
Copy link
Collaborator

IBFT E2E tests https://github.com/0xPolygon/polygon-edge/actions/runs/5319477440

@Nemanja0x Nemanja0x requested a review from vcastellm June 20, 2023 10:02
vcastellm
vcastellm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nemanja0x Nemanja0x closed this Jun 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
@Nemanja0x Nemanja0x reopened this Jun 21, 2023
@Nemanja0x Nemanja0x changed the title Max fault nodes for IBFT TestPoAPoSSwitch fixed Jun 21, 2023
@Nemanja0x Nemanja0x self-assigned this Jun 21, 2023
@Nemanja0x Nemanja0x added the bug Something isn't working label Jun 21, 2023
@Nemanja0x Nemanja0x requested a review from vcastellm June 21, 2023 11:58
@Nemanja0x Nemanja0x merged commit c2d4821 into develop Jun 22, 2023
7 checks passed
@Nemanja0x Nemanja0x deleted the EVM-699 branch June 22, 2023 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@dusan-maksimovic dusan-maksimovic Awaiting requested review from dusan-maksimovic

@stana-miric stana-miric Awaiting requested review from stana-miric

@jelacamarko jelacamarko Awaiting requested review from jelacamarko

@vcastellm vcastellm Awaiting requested review from vcastellm

Assignees

@Nemanja0x Nemanja0x

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nemanja0x @Stefan-Ethernal @vcastellm @igorcrevar @goran-ethernal