Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default mock tokens deployment from rootchain deploy command #1642

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Jun 20, 2023

Description

This PR cleans up deployment by not deploying mock tokens implementation for ERC 721 and ERC 1155 to the rootchain. Those addresses are also removed from the genesis bridge configuration as it turned out to be redundant and it was used solely for testing purposes.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-704-dont-deploy-mock-tokens-implementations-on-a-rootchain branch 2 times, most recently from b8336dc to 304cb3b Compare June 21, 2023 06:56
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review June 21, 2023 07:43
@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 21, 2023 07:44
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-704-dont-deploy-mock-tokens-implementations-on-a-rootchain branch from 304cb3b to 0c3e350 Compare June 22, 2023 08:50
@Stefan-Ethernal Stefan-Ethernal merged commit a152b79 into develop Jun 22, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-704-dont-deploy-mock-tokens-implementations-on-a-rootchain branch June 22, 2023 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants