Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DEBUG level log lines #1664

Merged

Conversation

jp-imx
Copy link
Contributor

@jp-imx jp-imx commented Jun 26, 2023

Added DEBUG level log lines when the transaction or deployment allowlists are applied to reject a transaction. This was helpful in testing the correct setup of the allowlists and blocklists.

Description

Whenever the transaction or deployment allowlist/blocklist rejects a transaction, we write a log line at DEBUG level.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Executed transactions on a local deployment and reviewed the log output.

Documentation update

N/A

Additional comments

N/A

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just pay attention to fixing linter errors.

@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 26, 2023 16:39
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jp-imx
Copy link
Contributor Author

jp-imx commented Jun 27, 2023

@Stefan-Ethernal I've addressed the linter issues. I need a hand with the failing build as it's unrelated to my changes, and I can't kick off a re-run.

@Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal I've addressed the linter issues. I need a hand with the failing build as it's unrelated to my changes, and I can't kick off a re-run.

Fallen E2E test is flaky one, but anyways I've re-run E2E tests.

@Stefan-Ethernal Stefan-Ethernal merged commit 1ab1a31 into 0xPolygon:develop Jun 27, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants