Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded script to check both dependencies #1667

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Upgraded script to check both dependencies #1667

merged 1 commit into from
Jun 27, 2023

Conversation

criadoperez
Copy link
Contributor

Description

Upgraded cluster script to check both dependencies and display all missing ones before exiting.
It was checking for jq but not for nc.

Changes include

  • [x ] Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [ x] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 27, 2023 11:54
vcastellm
vcastellm approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm vcastellm merged commit 36fa7a6 into 0xPolygon:develop Jun 27, 2023
4 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
@criadoperez criadoperez deleted the feat/makefile branch June 27, 2023 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@criadoperez @vcastellm @Stefan-Ethernal @goran-ethernal