Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ERC721 and ERC1155 bridge tests #1671

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Fix flaky ERC721 and ERC1155 bridge tests #1671

merged 2 commits into from
Jun 27, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Jun 27, 2023 •
edited

Description

PR increases how many blocks we are waiting for state sync events to be executed on the child chain. This should decrease the chances that tests fail.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Jun 27, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Jun 27, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 27, 2023 08:49
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review June 27, 2023 08:53
@Stefan-Ethernal Stefan-Ethernal merged commit 1bfb902 into develop Jun 27, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/flaky-bridge-nft-e2e-tests branch June 27, 2023 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stefan-Ethernal @Nemanja0x @goran-ethernal