Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/script cluster #1678

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

criadoperez
Copy link
Contributor

Description

  • Fixed a bug checking dependencies. Missing a space on new line 26
  • Added check if docker-compose is installed check --docker flag is used
  • Added help instructions to use the script. Help is displayed when:
    • --help flag is on
    • when script is executed with no commands ./script/cluster
    • a command has an incorrect value, like ./script/cluster xxx

New help command display:

% ./scripts/cluster --help 
Usage: cluster {consensus} [{command}] [{flags}]
Consensus:
  ibft            Start Supernets test environment locally with ibft consensus
  polybft         Start Supernets test environment locally with polybft consensus
Commands:
  stop            Stop the running environment
  destroy         Destroy the running environment
Flags:
  --docker        Run using Docker (requires docker-compose).
  --help          Display this help information
Examples:
  cluster polybft -- Run the script with the polybft consensus
  cluster polybtt --docker -- Run the script with the polybft consensus using docker
  cluster polybft stop -- Stop the running environment

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

scripts/cluster Show resolved Hide resolved
scripts/cluster Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 29, 2023 09:04
@criadoperez
Copy link
Contributor Author

Fixed the conflict. Ready to merge.

@Stefan-Ethernal Stefan-Ethernal merged commit c3e23fa into 0xPolygon:develop Jul 20, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@criadoperez criadoperez deleted the feat/script-cluster branch July 21, 2023 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants