Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/evm 719 #1683

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Fix/evm 719 #1683

merged 3 commits into from
Jun 30, 2023

Conversation

rachit77
Copy link
Contributor

Description

This PR solved the nil pointer dereference issue for PeerMap

Logs of the noticed behavior:

[WARN]  polygon.server.syncer.sync-peer-client: failed to get status from a peer, skip: id=16Uiu2HAmEKVGNXmVM6gMwL9XBLc1LmS1cCWMBdnwVvKJwmJegUSf err="rpc error: code = Unavailable desc = connection error: desc = \"error reading server preface: stream reset\""
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15a5759]

Jira Issue:Here

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@rachit77 rachit77 added the bug fix Functionality that fixes a bug label Jun 29, 2023
@rachit77 rachit77 self-assigned this Jun 29, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachit77 rachit77 merged commit b45a404 into 0xPolygon:develop Jun 30, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants