Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump libp2p #1684

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Bump libp2p #1684

merged 1 commit into from
Jun 30, 2023

Conversation

vcastellm
Copy link
Contributor

Description

Upgrade libp2p lib dependency

Changes include

  • Chore
  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@vcastellm
Bump libp2p
708cad4 
Upgrade libp2p lib dependency
@vcastellm vcastellm requested a review from a team June 29, 2023 14:21
@vcastellm vcastellm self-assigned this Jun 29, 2023
@vcastellm vcastellm added bug fix Functionality that fixes a bug chore and removed bug fix Functionality that fixes a bug labels Jun 29, 2023
@vcastellm vcastellm marked this pull request as ready for review June 29, 2023 14:22
@Stefan-Ethernal
Copy link
Collaborator

Just curious, this dependency is deliberately ignored by Dependabot?

@vcastellm vcastellm merged commit dcc6950 into develop Jun 30, 2023
6 checks passed
@vcastellm vcastellm deleted the EVM-725-upgrade-libp-2-p branch June 30, 2023 07:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
@vcastellm
Copy link
Contributor Author

Just curious, this dependency is deliberately ignored by Dependabot?

Not sure, maybe we blocked upgrades in the past because of incompatibilities.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcastellm @Stefan-Ethernal @goran-ethernal