Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure premining reserve account (0x0 address) #1685

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Ensure premining reserve account (0x0 address) #1685

merged 2 commits into from
Jul 4, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR introduces a validation to the genesis command, which ensures that escrow account is premined with some tokens inside genesis. This is important for minting and burning native tokens.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Jun 29, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 29, 2023 15:43
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jun 29, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-724-premine-0-x-0-address-should-be-mandatory branch from 6082fe9 to 1233cd0 Compare June 29, 2023 15:45
vcastellm
vcastellm approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from terminology

@goran-ethernal goran-ethernal changed the title Ensure premining escrow account (0x0 address) Ensure premining reserve account (0x0 address) Jul 4, 2023
@goran-ethernal goran-ethernal force-pushed the EVM-724-premine-0-x-0-address-should-be-mandatory branch from ad155cc to a4e346c Compare July 4, 2023 09:24
@vcastellm vcastellm merged commit 4cf4b79 into develop Jul 4, 2023
6 of 7 checks passed
@vcastellm vcastellm deleted the EVM-724-premine-0-x-0-address-should-be-mandatory branch July 4, 2023 13:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Stefan-Ethernal @vcastellm @igorcrevar @stana-miric @goran-ethernal