Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-739]: Fix eth_feeHistory parsing of hex arguments #1725

Merged
merged 3 commits into from
Jul 17, 2023
Merged

[EVM-739]: Fix eth_feeHistory parsing of hex arguments #1725

merged 3 commits into from
Jul 17, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jul 14, 2023 •
edited

Description

eth_feeHistory rpc endpoint did not parse hex values for arguments blockCount and newestBlock.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal self-assigned this Jul 14, 2023
@goran-ethernal goran-ethernal requested a review from a team July 14, 2023 14:18
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Jul 14, 2023
@goran-ethernal goran-ethernal force-pushed the EVM-739-eth_feeHistory_does_not_parse_hex_arguments branch from 2405f52 to b5d12c0 Compare July 14, 2023 14:19
@goran-ethernal goran-ethernal marked this pull request as ready for review July 14, 2023 14:19
@igorcrevar
Copy link
Contributor

I have approved but I just saw that type feeHistoryResult struct does not have correct json annotations. Please put those before merge

@goran-ethernal
Copy link
Collaborator Author

@igorcrevar Done: 34599c7

@goran-ethernal goran-ethernal merged commit 5ea0540 into develop Jul 17, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-739-eth_feeHistory_does_not_parse_hex_arguments branch July 17, 2023 07:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@rachit77 rachit77 rachit77 approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@goran-ethernal @igorcrevar @vcastellm @rachit77 @Stefan-Ethernal