Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-746 Fix txpool_content and txpool_inspect for dynamic fee txs #1741

Merged
merged 2 commits into from
Jul 24, 2023
Merged

EVM-746 Fix txpool_content and txpool_inspect for dynamic fee txs #1741

merged 2 commits into from
Jul 24, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Jul 24, 2023 •
edited

Description

txpoolTransaction structure has been deleted. txpool_content endpoint should use transaction from same package.
txpool_inspect should work for dynamic fee txs also

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jul 24, 2023
@igorcrevar igorcrevar requested a review from a team July 24, 2023 10:57
@igorcrevar igorcrevar self-assigned this Jul 24, 2023
@igorcrevar igorcrevar mentioned this pull request Jul 24, 2023
Closed
10 tasks
vcastellm
vcastellm approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm vcastellm merged commit 13e82b6 into develop Jul 24, 2023
6 checks passed
@vcastellm vcastellm deleted the feature/EVM-746 branch July 24, 2023 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@begmaroman begmaroman Awaiting requested review from begmaroman

@rachit77 rachit77 Awaiting requested review from rachit77

@dusan-maksimovic dusan-maksimovic Awaiting requested review from dusan-maksimovic

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorcrevar @vcastellm @Stefan-Ethernal