Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Encode* and Parse* functions from types to common package #1765

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Aug 1, 2023

Description

Moves types.Parse* (e.g. ParseUint64OrHex etc.) and types.Encode* (e.g. EncodeUint64 etc.) to the common package in order to remove redundant ParseUint64OrHex function.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Nemanja0x
Copy link
Contributor

Nemanja0x commented Aug 2, 2023

types package keeps additional functions: ParseUint256orHex, ParseBytes, ... Isn't it better to keep ParseUint64orHex inside types and remove it from common? Otherwise, ParseUint256orHex will be a part of types and ParseUint64orHex will be a part of common

@Stefan-Ethernal
Copy link
Collaborator Author

Stefan-Ethernal commented Aug 2, 2023

types package keeps additional functions: ParseUint256orHex, ParseBytes, ... Isn't it better to keep ParseUint64orHex inside types and remove it from common? Otherwise, ParseUint256orHex will be a part of types and ParseUint64orHex will be a part of common

Yes it would be better, however it is not possible because of this function:
https://github.com/0xPolygon/polygon-edge/blob/develop/helper/common/common.go#L83-L97 (it uses ParseUint64OrHex and it is not possible to move it to types package because of circular imports).

If you want, we could move all the other Parse* functions from the types to the common package. WDYT?

@Stefan-Ethernal Stefan-Ethernal changed the title Remove types.ParseUint64orHex and use the one from common package Move Encode* and Parse* functions from types to common package Aug 2, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 2b9430c into develop Aug 2, 2023
6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/remove-deprecated-parseuint64orhex branch August 2, 2023 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants