Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change chainID to chainId #1766

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Change chainID to chainId #1766

merged 1 commit into from
Aug 1, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Aug 1, 2023 •
edited

Description

Addressing #1757

https://github.com/ethereum/go-ethereum/blob/master/core/types/transaction_marshalling.go#L33

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Aug 1, 2023
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label Aug 1, 2023
@Stefan-Ethernal Stefan-Ethernal linked an issue Aug 1, 2023 that may be closed by this pull request
Transaction type 2 (EIP1559) has chainID = 0 #1757
Closed
@begmaroman begmaroman merged commit 4653fea into develop Aug 1, 2023
6 checks passed
@begmaroman begmaroman deleted the fix/EVM-753 branch August 1, 2023 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

@vcastellm vcastellm Awaiting requested review from vcastellm

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction type 2 (EIP1559) has chainID = 0
3 participants
@begmaroman @Stefan-Ethernal @goran-ethernal