Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-757]: Some commands did not print out errors returned by tx relayer #1768

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[EVM-757]: Some commands did not print out errors returned by tx relayer #1768

merged 1 commit into from
Aug 1, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Aug 1, 2023 •
edited
Loading

Description

This PR fixes the issue where some commands did not print out errors returned by tx relayer to command output.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal requested a review from a team August 1, 2023 13:26
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Aug 1, 2023
@goran-ethernal goran-ethernal marked this pull request as ready for review August 1, 2023 13:26
@goran-ethernal goran-ethernal merged commit 65c9a3e into develop Aug 1, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
@goran-ethernal goran-ethernal deleted the EVM-757-Some-commands-are-not-printing-out-returned-errors branch August 1, 2023 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees
No one assigned
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goran-ethernal @Nemanja0x @Stefan-Ethernal