Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metrics that tracks the base fee #1784

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

jp-imx
Copy link
Contributor

@jp-imx jp-imx commented Aug 7, 2023

Description

I couldn't find a metric in Prometheus to monitor gas price, so I added this one. If there's already something I can use I'm happy to adopt it and close this.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however, since this part of code is IBFT consensus protocol related, which is basically obsoleted, don't forget to register gauge here as well, which is related to polybft:
https://github.com/jp-imx/polygon-edge/blob/jp/add-basefee-gauge/consensus/polybft/consensus_metrics.go#L37

Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jp-imx . Thanks for the PR. You added this metric only for ibft.

To actually add it for polybft, please check out file consensus/polybft/consensus_metrics.go, function updateBlockMetrics. You can add the given metric there.

@jp-imx
Copy link
Contributor Author

jp-imx commented Aug 7, 2023

Thanks for pointing that out @Stefan-Ethernal and @goran-ethernal. I've now updated this

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cc @DannyS03 in order to update docs if necessary.

@Stefan-Ethernal Stefan-Ethernal changed the title NOTICKET: adding a gauge to monitor how the base fee moves over time Implement metrics that tracks the base fee Aug 8, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit e0e1e36 into 0xPolygon:develop Aug 8, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants