Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use curl instead of netcat in local deployment script #1791

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Aug 8, 2023

Description

This PR uses curl instead of Netcat for pinging rootchain server, because it is more widely used tool and chances are it is pre-installed with the OS.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Aug 8, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Aug 8, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Use curl instead of netcat in local deployment script Use curl instead of netcat in local deployment script Aug 8, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team August 8, 2023 11:34
@Stefan-Ethernal Stefan-Ethernal merged commit 5db2845 into develop Aug 9, 2023
4 of 6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/use-curl-instead-of-net-cat branch August 9, 2023 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants