-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send dynamic fee transactions to a rootchain #1795
Merged
Stefan-Ethernal
merged 16 commits into
develop
from
EVM-758-use-eip-1559-transactions-for-checkpoints
Aug 15, 2023
Merged
Send dynamic fee transactions to a rootchain #1795
Stefan-Ethernal
merged 16 commits into
develop
from
EVM-758-use-eip-1559-transactions-for-checkpoints
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
EVM-758-use-eip-1559-transactions-for-checkpoints
branch
from
August 9, 2023 10:16
2e991cd
to
e4242e6
Compare
Stefan-Ethernal
force-pushed
the
EVM-758-use-eip-1559-transactions-for-checkpoints
branch
from
August 10, 2023 12:05
5160407
to
af109eb
Compare
Stefan-Ethernal
changed the title
Create dynamic fee tx for checkpoint submission
Create dynamic fee tx for rootchain
Aug 10, 2023
Stefan-Ethernal
changed the title
Create dynamic fee tx for rootchain
Send dynamic fee transactions to a rootchain
Aug 10, 2023
goran-ethernal
approved these changes
Aug 11, 2023
Nemanja0x
reviewed
Aug 12, 2023
Nemanja0x
approved these changes
Aug 14, 2023
Stefan-Ethernal
deleted the
EVM-758-use-eip-1559-transactions-for-checkpoints
branch
August 15, 2023 09:10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sends a dynamic fee transaction for all of the root chain transactions, since there were some issues when Supernets was having the root chain set to the Sepolia network, as checkpoint submission transactions were underpriced.
If sending dynamic fee transaction fails, it fallbacks to legacy transaction and tries resending it.
It also fixes the transaction hash calculation, because it was not correct for access list transactions.
Changes include
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it