Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send dynamic fee transactions to a rootchain #1795

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Aug 8, 2023

Description

This PR sends a dynamic fee transaction for all of the root chain transactions, since there were some issues when Supernets was having the root chain set to the Sepolia network, as checkpoint submission transactions were underpriced.
If sending dynamic fee transaction fails, it fallbacks to legacy transaction and tries resending it.

It also fixes the transaction hash calculation, because it was not correct for access list transactions.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal self-assigned this Aug 8, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Aug 8, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft August 9, 2023 07:39
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-758-use-eip-1559-transactions-for-checkpoints branch from 2e991cd to e4242e6 Compare August 9, 2023 10:16
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-758-use-eip-1559-transactions-for-checkpoints branch from 5160407 to af109eb Compare August 10, 2023 12:05
@Stefan-Ethernal Stefan-Ethernal changed the title Create dynamic fee tx for checkpoint submission Create dynamic fee tx for rootchain Aug 10, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Create dynamic fee tx for rootchain Send dynamic fee transactions to a rootchain Aug 10, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team August 11, 2023 05:54
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review August 11, 2023 05:54
@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft August 11, 2023 06:02
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review August 11, 2023 10:00
txrelayer/txrelayer.go Outdated Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal merged commit 6862b7d into develop Aug 15, 2023
6 of 7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-758-use-eip-1559-transactions-for-checkpoints branch August 15, 2023 09:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants