Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header.BaseFee is set to non-zero for london fork disabled #1805

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Aug 11, 2023

Description

Return zero basefee if the london hardfork is disabled

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Aug 11, 2023
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label Aug 11, 2023
@begmaroman begmaroman marked this pull request as ready for review August 11, 2023 10:27
@begmaroman begmaroman marked this pull request as draft August 11, 2023 12:26
@begmaroman
Copy link
Contributor Author

Tested manually. Sent several transactions with disabled london hardfork via Metamask.

@begmaroman begmaroman marked this pull request as ready for review August 14, 2023 10:34
@Nemanja0x
Copy link
Contributor

Nemanja0x commented Aug 14, 2023

One thing to remember, maybe I'll create a ticket. If we have london fork disabled and we enable it at block 100: It can happen that a node which is started after block 100 has different hash of genesis block. This is because genesis header will use the new configuration where the baseFee is not 0. Nevertheless, if this is assumption is correct, it is a new bug. The one reported here is solved.

@begmaroman begmaroman merged commit c860c52 into develop Aug 14, 2023
6 checks passed
@begmaroman begmaroman deleted the feature/EVM-772 branch August 14, 2023 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants