[Feature] Double-signing slashing #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add governorAdmin flag * Comments fix
* Add proposal-quorum flag * Comments fix
…1735) * Move distribute rewards to first block of epoch * Modification of reward distribution as part of governance fork * Small change * Comments fix
* Add contracts * Fix integration test
…proposals (#1749) * GovernanceManager * PostEpoch * PostBlock and update of client config * Lint fix * UTs * Comments fix * Retry in PostEpoch as well * Comments fix
* Governance e2e tests * Comments fix
* Add forks activation based on ForkParams contract * Comments fix
* Double signing tracker (draft) * Track all messages and detect double signing by comparing signatures * Address comments * Add mutex, fix double sign detection * Unit tests (part 1) * PruneMsgsUntil unit test * tracker.Handle multiple senders UT * Address comments * Updated comment * GetEvidences UT * Remove redundant variable * Add missing mutex calls * Protect from spammers in tracker * Ignore messages sent by non-validators (#1767) * Filter messages which are not sent by known validators in double signing tracker * Init double signing tracker only when stake store is populated with validators * Fix tests * Fix GetEvidences UT * Simplification in add message fn * Add comments * Deterministic IBFT message types iterating * Make linter happy (again) * Simplify GetEvidences, since messages with unique signatures are added into the storage * Rename GetValidators to GetAllValidators * Send messages from a separate routine * Run IBFT messages handling in parallel
* Simplification * Suppress linting error
Stefan-Ethernal
force-pushed
the
feat/slashing
branch
from
0caa63c
to
49bc267
Compare
* Provide only 2 messages per evidence * Introduce MinAddressHeap and use it to store addresses sorted * Add min round heap to keep rounds sorted * Use sorted slice instead of heap for rounds and addresses * Prevent adding the same address and rounds multiple times * Remove SortedMessages structure * Add randomized test * Messages.stringer * Linter fix * Make randomized test working * Fix GetDoubleSigners property test * Rename * Unexport Min function * Cleanup * Release lock if there are no msgs for the given height
* slashing state transaction creation and validation * ut fixes * CR fixes * linter fix
* Byzantine node testing * minor fix * lint fix * CR fix * CR fix * New byzantine binary --------- Co-authored-by: Nemanja0x <nemanja@ethernal.tech>
…tManager contracts (#1822)
goran-ethernal
force-pushed
the
feat/on-chain-governance
branch
from
7a8b5e0
to
4a92ab0
Compare
Nemanja0x
approved these changes
Sep 5, 2023
igorcrevar
approved these changes
Sep 5, 2023
goran-ethernal
approved these changes
Sep 5, 2023
goran-ethernal
force-pushed
the
feat/on-chain-governance
branch
from
1a1b624
to
3c9262c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Double signers are malicious validators who have signed more than 1 message of the same type, with different hash in the given round. The aim of this feature is to track such malicious behavior and punish it by slashing a portion of the stake.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it