Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-779 Throttling with concurrency #1821

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Aug 16, 2023

Description

Instead of using requests per second measure to refuse request, use different approach:
Only --concurrent-requests-debug (default 32) requests are allowed to be executed concurrently for all the debug endpoints

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar self-assigned this Aug 16, 2023
@igorcrevar igorcrevar added the feature New update to Polygon Edge label Aug 16, 2023
@igorcrevar igorcrevar requested a review from a team August 16, 2023 13:11
@igorcrevar igorcrevar marked this pull request as draft August 16, 2023 13:13
jsonrpc/throttling.go Outdated Show resolved Hide resolved
jsonrpc/throttling.go Outdated Show resolved Hide resolved
jsonrpc/throttling.go Outdated Show resolved Hide resolved
jsonrpc/throttling.go Outdated Show resolved Hide resolved
jsonrpc/throttling.go Outdated Show resolved Hide resolved
@igorcrevar igorcrevar force-pushed the EVM-779_circular_buffer_instead_of_bin_heap branch from a0efadf to eb98f0e Compare August 16, 2023 13:46
@igorcrevar igorcrevar marked this pull request as ready for review August 16, 2023 14:10
@igorcrevar igorcrevar force-pushed the EVM-779_circular_buffer_instead_of_bin_heap branch from 3388e8b to 07c123b Compare August 17, 2023 10:31
@igorcrevar igorcrevar changed the title EVM-779 Throttling - circular buffer instead of binary heap EVM-779 Throttling with concurrency Aug 17, 2023
@igorcrevar igorcrevar force-pushed the EVM-779_circular_buffer_instead_of_bin_heap branch from 07c123b to d7443e6 Compare August 17, 2023 10:34
@igorcrevar igorcrevar force-pushed the EVM-779_circular_buffer_instead_of_bin_heap branch 2 times, most recently from 200de70 to fc521f5 Compare August 17, 2023 14:38
jsonrpc/throttling.go Outdated Show resolved Hide resolved
@igorcrevar igorcrevar force-pushed the EVM-779_circular_buffer_instead_of_bin_heap branch from 35c980e to b90c91e Compare August 18, 2023 08:21
@igorcrevar igorcrevar merged commit 883cbbc into develop Aug 18, 2023
6 of 7 checks passed
@igorcrevar igorcrevar deleted the EVM-779_circular_buffer_instead_of_bin_heap branch August 18, 2023 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants