Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Test_GetLogsForQuery #1836

Merged

Conversation

sarvalabs-shravanth
Copy link
Contributor

@sarvalabs-shravanth sarvalabs-shravanth commented Aug 20, 2023

Description

Resolves #1835

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@github-actions
Copy link

github-actions bot commented Aug 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sarvalabs-shravanth
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Stefan-Ethernal
Copy link
Collaborator

Hey @sarvalabs-shravanth, tnx for the PR. Notice that linting is failing, so just please fix it and we are good to go with merging it after you gain one more approval 🙂

@Stefan-Ethernal Stefan-Ethernal requested a review from a team August 30, 2023 11:18
- Review changes suggested in PR 0xPolygon#1787
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx for the contribution!

@vcastellm vcastellm merged commit ece1c5e into 0xPolygon:develop Sep 1, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix Test_GetLogsForQuery
4 participants