Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UUID issue #1841

Merged
merged 4 commits into from
Aug 22, 2023
Merged

UUID issue #1841

merged 4 commits into from
Aug 22, 2023

Conversation

rachit77
Copy link
Contributor

Description

This PR aims to solve the issue highlighted here i.e. to return filterID in hex format instead of uuid

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@rachit77 rachit77 added the bug fix Functionality that fixes a bug label Aug 21, 2023
@rachit77 rachit77 self-assigned this Aug 21, 2023
vcastellm
vcastellm approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachit77 rachit77 merged commit 2f430d0 into 0xPolygon:develop Aug 22, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@begmaroman begmaroman begmaroman approved these changes

@dusan-maksimovic dusan-maksimovic Awaiting requested review from dusan-maksimovic

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

Assignees

@rachit77 rachit77

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rachit77 @vcastellm @igorcrevar @begmaroman