Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer panic in debug_traceBlockByNumber RPC endpoint #1842

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Fix nil pointer panic in debug_traceBlockByNumber RPC endpoint #1842

merged 2 commits into from
Aug 21, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Aug 21, 2023 •
edited

Description

#1837

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman added the bug fix Functionality that fixes a bug label Aug 21, 2023
@begmaroman begmaroman self-assigned this Aug 21, 2023
@begmaroman begmaroman linked an issue Aug 21, 2023 that may be closed by this pull request
calling debug_traceBlockByNumber api method on an edge node panics. #1837
Closed
@begmaroman begmaroman marked this pull request as ready for review August 21, 2023 14:26
@begmaroman begmaroman merged commit 2684cc5 into develop Aug 21, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
@begmaroman begmaroman deleted the feature/EVM-791 branch August 21, 2023 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@rachit77 rachit77 rachit77 approved these changes

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calling debug_traceBlockByNumber api method on an edge node panics.
3 participants
@begmaroman @vcastellm @rachit77