Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform gas price limit check for dynamic tx #1846

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Perform gas price limit check for dynamic tx #1846

merged 5 commits into from
Aug 24, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Aug 23, 2023 •
edited

Description

Currently, there is a check that compares the gas price of a legacy tx with the gas price limit specified per node argument.
This check should be applicable for dynamic tx as well.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Aug 23, 2023
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label Aug 23, 2023
@begmaroman begmaroman marked this pull request as ready for review August 23, 2023 08:55
rachit77
rachit77 reviewed Aug 23, 2023
View reviewed changes
txpool/txpool.go Outdated Show resolved Hide resolved
vcastellm
vcastellm approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

igorcrevar
igorcrevar reviewed Aug 24, 2023
View reviewed changes
txpool/txpool.go Outdated Show resolved Hide resolved
@begmaroman begmaroman merged commit 2fea208 into develop Aug 24, 2023
6 checks passed
@begmaroman begmaroman deleted the fix/EVM-794 branch August 24, 2023 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@rachit77 rachit77 rachit77 approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@begmaroman @vcastellm @igorcrevar @rachit77 @Nemanja0x