Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxFeePerGas compensation calculation #1847

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

MaxFeePerGas was calculated as the sum(latest base fee, max priority fee per gas) increased by 20 times that amount, instead 20% increase. There was lacking division by 100 to transfer it to percentage. This PR fixes it.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

@Stefan-Ethernal Stefan-Ethernal self-assigned this Aug 23, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Aug 23, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team August 23, 2023 19:20
@Stefan-Ethernal Stefan-Ethernal merged commit 1794897 into develop Aug 24, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/max-fee-per-gas-compensation-tx-relayer branch August 24, 2023 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants