EVM-805 TxPool assumes all transactions are Legacy when checking for re-priceaction replacement GasPrice comparison bug #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
force-pushed
the
feature/EVM-799_tx_replacement_bug_fix
branch
from
927748e
to
f52953f
Compare
igorcrevar
changed the title
Nemanja0x
approved these changes
Aug 25, 2023
stana-miric
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears it’s currently impossible to reprice Dynamic Fee transactions (i.e., EIP-1559 txs).
The check in the txpool only takes into account GasPrice, which means that reprice attempts are rejected because nil == nil and the price comparison appears to be equal.Also, if the re-price transaction is a Legacy transaction, the application does a nil deference and it goes into a panic. I’m certain (although I haven’t tested it) the same will happen if a Legacy transaction is repriced by a Dynamic Fee transaction.
Changes include
Checklist
Testing