Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all exit event IDs in the bridge commands #1863

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

jelacamarko
Copy link
Contributor

Description

ExtractExitEventID function is changed, so now it returns an array of all exit events IDs, that are matched from receipt logs.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@jelacamarko jelacamarko requested a review from a team August 30, 2023 13:21
@jelacamarko jelacamarko self-assigned this Aug 30, 2023
command/bridge/common/params.go Show resolved Hide resolved
command/bridge/common/params.go Outdated Show resolved Hide resolved
@jelacamarko jelacamarko merged commit 21c5c33 into develop Sep 1, 2023
7 checks passed
@jelacamarko jelacamarko deleted the evm-773 branch September 1, 2023 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants