Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-801 Drop tx bug for updateAccountSkipsCounts #1865

Merged
merged 3 commits into from
Sep 1, 2023
Merged

EVM-801 Drop tx bug for updateAccountSkipsCounts #1865

merged 3 commits into from
Sep 1, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Sep 1, 2023 •
edited by rachit77

Description

There was issue for non validator node in txpool: updateAccountSkipsCounts did not set correct nonce after dropping
first (enqueued or promoted) transaction.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Sep 1, 2023
@igorcrevar igorcrevar requested a review from a team September 1, 2023 08:37
@igorcrevar igorcrevar self-assigned this Sep 1, 2023
rachit77
rachit77 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@rachit77 rachit77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vcastellm
vcastellm approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorcrevar igorcrevar merged commit 064b017 into develop Sep 1, 2023
5 of 6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-801 branch September 1, 2023 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@begmaroman begmaroman begmaroman approved these changes

@rachit77 rachit77 rachit77 approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@igorcrevar @vcastellm @begmaroman @rachit77 @stana-miric